minor code style #469
Open
minor code style #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 85.97%@@ master #469 diff @@
==========================================
Files 40 40
Lines 4768 4769 +1
Methods 0 0
Messages 0 0
Branches 654 654
==========================================
+ Hits 4096 4100 +4
Misses 513 513
+ Partials 159 156 -3
|
| @@ -215,7 +215,7 @@ for cmd in "$@"; do | |||
| fi | |||
| done | |||
|
|
|||
| if [ $UNKNOWN -eq 1 ]; then | |||
| if [ ${UNKNOWN} -eq 1 ]; then | |||
|
Thanks for the cleanup, and sorry it took so long to review! Most changes are good, but I'm not sure I like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.