Skip to content

Conversation

Gallaecio
Copy link
Member

  • Use bold face instead of italics for the first mention of the library name
  • Move the license and language from the list of facts into the first paragraph
  • Removed the list of supported Python versions, already indicated by batches, and not too important given that all non-EOL Python versions are supported
  • Remove title case from “CSS3 Selectors” (→ CSS3 selectors)
  • Move what XPath expressions allow to a separate paragraph, since that is not a core part of cssselect; cssselect use cases do not necessarily involve passing the result to an XML parser like lxml
  • Remove the paragraph about cssselect being part of lxml in the past. It’s irrelevant for new users
  • Moved the reference to the online documentation into a paragraph of its own, with the URL as display text

@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #103 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files           2        2           
  Lines         754      754           
  Branches      128      128           
=======================================
  Hits          720      720           
  Misses         19       19           
  Partials       15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb40f21...351f253. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #103 (0dc1380) into master (79c341b) will not change coverage.
The diff coverage is n/a.

❗ Current head 0dc1380 differs from pull request most recent head 01eb4d1. Consider uploading reports for the commit 01eb4d1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files           3        3           
  Lines         763      763           
  Branches      130      130           
=======================================
  Hits          727      727           
  Misses         20       20           
  Partials       16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79c341b...01eb4d1. Read the comment docs.

Copy link

@nyov nyov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@elacuesta elacuesta merged commit 7bc326d into scrapy:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants