-
Notifications
You must be signed in to change notification settings - Fork 61
Add matches-any pseudo-class: ':is()' #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
+ Coverage 95.28% 95.39% +0.11%
==========================================
Files 3 3
Lines 763 803 +40
Branches 130 139 +9
==========================================
+ Hits 727 766 +39
Misses 20 20
- Partials 16 17 +1
Continue to review full report at Codecov.
|
Please, add tests to cover the new code. Existing tests should help you, and you can use https://codecov.io/gh/scrapy/cssselect/pull/109/diff to see which modified or added lines or code are currently not being covered by the tests. |
This pull request is aimed at trying to solve issue #67 by adding support for the Matches-Any Pseudo-class
:is()
. I have tried out the XPath expressions produced from examples ofis()
usage here and here and they seem to be correct. I'm hoping to work on adding more CSS Selectors Level 4 support as part of GSoC.