Skip to content

Conversation

julius383
Copy link
Contributor

This pull request is aimed at trying to solve issue #67 by adding support for the Matches-Any Pseudo-class :is(). I have tried out the XPath expressions produced from examples of is() usage here and here and they seem to be correct. I'm hoping to work on adding more CSS Selectors Level 4 support as part of GSoC.

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #109 (1ab9f30) into master (79c341b) will increase coverage by 0.11%.
The diff coverage is 97.61%.

❗ Current head 1ab9f30 differs from pull request most recent head 2547d6a. Consider uploading reports for the commit 2547d6a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   95.28%   95.39%   +0.11%     
==========================================
  Files           3        3              
  Lines         763      803      +40     
  Branches      130      139       +9     
==========================================
+ Hits          727      766      +39     
  Misses         20       20              
- Partials       16       17       +1     
Impacted Files Coverage Δ
cssselect/xpath.py 94.77% <90.00%> (-0.20%) ⬇️
cssselect/parser.py 95.73% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79c341b...2547d6a. Read the comment docs.

@Gallaecio
Copy link
Member

Please, add tests to cover the new code. Existing tests should help you, and you can use https://codecov.io/gh/scrapy/cssselect/pull/109/diff to see which modified or added lines or code are currently not being covered by the tests.

@elacuesta elacuesta changed the title Add :matches() pseudo-class Add matches-any pseudo-class: ':is()' Jun 30, 2021
@elacuesta elacuesta requested a review from wRAR June 30, 2021 12:25
@Gallaecio Gallaecio merged commit 599cbb5 into scrapy:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants