Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support kwargs for loader.*_xpath() #32

Closed
alexander-matsievsky opened this issue Aug 23, 2018 · 7 comments
Closed

Support kwargs for loader.*_xpath() #32

alexander-matsievsky opened this issue Aug 23, 2018 · 7 comments
Labels
enhancement New feature or request

Comments

@alexander-matsievsky
Copy link

Allow passing named variables and namespaces dict arguments on ItemLoader.*_xpath() family of methods (add_xpath, etc.).

Related scrapy/scrapy#2457.

@kmike
Copy link
Member

kmike commented Aug 23, 2018

See also: scrapy/scrapy#2950

@Gallaecio Gallaecio transferred this issue from scrapy/scrapy Oct 30, 2020
@Gallaecio Gallaecio added the enhancement New feature or request label Feb 21, 2021
@wRAR
Copy link
Member

wRAR commented Feb 26, 2023

I think this was done in #48?

@VMRuiz
Copy link
Contributor

VMRuiz commented Feb 27, 2023

@wRAR I would say yes.

However, I think is not added for *_css() methods. Does it make sense to implement it there too?

@Gallaecio Gallaecio reopened this Feb 27, 2023
@Gallaecio
Copy link
Member

Hmm… Does CSS syntax support variables, though? This may be XPath-specific.

@Gallaecio
Copy link
Member

Gallaecio commented Feb 27, 2023

If not, we may want to consider removing **kw from the _get_cssvalues signature, so I think it makes sense to keep this open either way.

@VMRuiz
Copy link
Contributor

VMRuiz commented Feb 27, 2023

There is no references to CSS variables in Parsel lib, so I guess there is no user case for this.

@VMRuiz
Copy link
Contributor

VMRuiz commented Feb 27, 2023

If not, we may want to consider removing **kw from the _get_cssvalues signature, so I think it makes sense to keep this open either way.

Let's create a new issue for that to avoid having issues open forever 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants