Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #4

Merged
merged 33 commits into from
May 5, 2020
Merged

Documentation #4

merged 33 commits into from
May 5, 2020

Conversation

ejulio
Copy link
Collaborator

@ejulio ejulio commented Apr 29, 2020

Split documentation into multiple files (one per topic).
Removed scrapy references

Probably there's some work to be done in terms of rewriting and updating configurations (kept from scrapy docs)

@ejulio ejulio mentioned this pull request Apr 29, 2020
@ejulio ejulio marked this pull request as ready for review May 2, 2020 22:08
Copy link

@victor-torres victor-torres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Next time you could split these changes across two different pull requests:

  • first one moving commits from old repository
  • another one making your latest changes

That would make it easier to review/approve.

docs/README.rst Outdated Show resolved Hide resolved
docs/api-reference.rst Show resolved Hide resolved
@ejulio
Copy link
Collaborator Author

ejulio commented May 4, 2020

@victor-torres , thanks for the tip.
Indeed, most of the history was in master, here I kept only the history for docs setup

@victor-torres
Copy link

@victor-torres , thanks for the tip.
Indeed, most of the history was in master, here I kept only the history for docs setup

Do we need to merge #1 first?

@ejulio ejulio changed the base branch from master to cleanup May 5, 2020 11:01
@ejulio
Copy link
Collaborator Author

ejulio commented May 5, 2020

@kmike @victor-torres I've changed the base, so we can merge this one to cleanup

docs/api-reference.rst Outdated Show resolved Hide resolved
docs/api-reference.rst Outdated Show resolved Hide resolved
docs/built-in processors.rst Outdated Show resolved Hide resolved
docs/built-in processors.rst Outdated Show resolved Hide resolved
docs/declaring-loaders.rst Outdated Show resolved Hide resolved
docs/extending-loaders.rst Outdated Show resolved Hide resolved
docs/extending-loaders.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
docs/index.rst Show resolved Hide resolved
docs/processors.rst Outdated Show resolved Hide resolved
docs/loaders-context.rst Outdated Show resolved Hide resolved
ejulio and others added 2 commits May 5, 2020 09:55
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
@codecov-io
Copy link

codecov-io commented May 5, 2020

Codecov Report

Merging #4 into cleanup will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           cleanup       #4   +/-   ##
========================================
  Coverage    98.02%   98.02%           
========================================
  Files            4        4           
  Lines          253      253           
========================================
  Hits           248      248           
  Misses           5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c4dc1...34c4dc1. Read the comment docs.

@kmike
Copy link
Member

kmike commented May 5, 2020

👍 nice! feel free to merge.

@ejulio ejulio merged commit e7c616c into cleanup May 5, 2020
@ejulio ejulio deleted the fix-docs branch May 5, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants