-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Next time you could split these changes across two different pull requests:
- first one moving commits from old repository
- another one making your latest changes
That would make it easier to review/approve.
@victor-torres , thanks for the tip. |
Do we need to merge #1 first? |
@kmike @victor-torres I've changed the base, so we can merge this one to |
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
Enable travis CI
Codecov Report
@@ Coverage Diff @@
## cleanup #4 +/- ##
========================================
Coverage 98.02% 98.02%
========================================
Files 4 4
Lines 253 253
========================================
Hits 248 248
Misses 5 5 Continue to review full report at Codecov.
|
👍 nice! feel free to merge. |
Split documentation into multiple files (one per topic).
Removed scrapy references
Probably there's some work to be done in terms of rewriting and updating configurations (kept from scrapy docs)