Add explanation for argument 'base_url' #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
========================================
+ Coverage 99.66% 100% +0.33%
========================================
Files 5 5
Lines 296 296
Branches 52 52
========================================
+ Hits 295 296 +1
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
Gallaecio
approved these changes
Oct 31, 2019
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
Gallaecio
approved these changes
Nov 1, 2019
|
Thanks @pycrusher and @Gallaecio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that there was hardly any explanation for the argument 'base_url', which is eventually passed to lxml.etree.fromstring as a base URL for the current page, useful when we need to access relevant pages or resources via relative paths. This argument is not quite important for newcomers but I think it's inappropriate to ignore it in the doc.
I added a simple explanation about it into the script and provided a link to lxml api reference, which may be helpful for those who are interested in the source code.