Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Document copying of spider arguments to attributes #2483

Merged
merged 2 commits into from Jan 10, 2017

Conversation

@Digenis
Copy link
Member

@Digenis Digenis commented Jan 5, 2017

I refer to https://github.com/scrapy/scrapy/blob/1.3/scrapy/spiders/__init__.py#L30
I'm too verbose and I need some feedback to start editing out.
Also, should we include something about calling super() in subclasses?

@codecov-io
Copy link

@codecov-io codecov-io commented Jan 5, 2017

Current coverage is 83.43% (diff: 100%)

Merging #2483 into master will decrease coverage by 0.01%

@@             master      #2483   diff @@
==========================================
  Files           161        161          
  Lines          8780       8780          
  Methods           0          0          
  Messages          0          0          
  Branches       1288       1288          
==========================================
- Hits           7327       7326     -1   
  Misses         1205       1205          
- Partials        248        249     +1   

Powered by Codecov. Last update e7d0dae...900b671

@kmike kmike changed the title Document copying of spider arguments to attributes [MRG+1] Document copying of spider arguments to attributes Jan 8, 2017
@kmike
Copy link
Member

@kmike kmike commented Jan 8, 2017

A great addition to the docs 👍 This is an useful feature which was barely documented.

@Digenis
Copy link
Member Author

@Digenis Digenis commented Jan 9, 2017

How about the way I document it?
Isn't it too verbose?

@kmike
Copy link
Member

@kmike kmike commented Jan 9, 2017

No, I think the verbosity level is just right. I like the way you documented it.

Keep in mind that spider arguments are only strings.
The spider will not do any parsing on its own.
If you were to set the `start_urls` attribute from the command line,
you would have parse it on you own into a list

This comment has been minimized.

@Digenis

Digenis Jan 9, 2017
Author Member

typo: s/would have parse it/would have to parse it/
I'll amend it now.

@Digenis Digenis force-pushed the Digenis:doc_spider_args2attrs branch from 91c4d1a to 900b671 Jan 9, 2017
Keep in mind that spider arguments are only strings.
The spider will not do any parsing on its own.
If you were to set the `start_urls` attribute from the command line,
you would have to parse it on you own into a list

This comment has been minimized.

@voith

voith Jan 10, 2017

on you your own

@redapple redapple merged commit 4636bef into scrapy:master Jan 10, 2017
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@redapple
Copy link
Contributor

@redapple redapple commented Jan 10, 2017

Thank you @Digenis (and @voith )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.