[MRG+1] Document copying of spider arguments to attributes #2483
Conversation
Current coverage is 83.43% (diff: 100%)@@ master #2483 diff @@
==========================================
Files 161 161
Lines 8780 8780
Methods 0 0
Messages 0 0
Branches 1288 1288
==========================================
- Hits 7327 7326 -1
Misses 1205 1205
- Partials 248 249 +1
|
kmike
changed the title
|
A great addition to the docs |
|
How about the way I document it? |
|
No, I think the verbosity level is just right. I like the way you documented it. |
docs/topics/spiders.rst
Outdated
| Keep in mind that spider arguments are only strings. | ||
| The spider will not do any parsing on its own. | ||
| If you were to set the `start_urls` attribute from the command line, | ||
| you would have parse it on you own into a list |
Digenis
Jan 9, 2017
•
Author
Member
typo: s/would have parse it/would have to parse it/
I'll amend it now.
typo: s/would have parse it/would have to parse it/
I'll amend it now.
docs/topics/spiders.rst
Outdated
| Keep in mind that spider arguments are only strings. | ||
| The spider will not do any parsing on its own. | ||
| If you were to set the `start_urls` attribute from the command line, | ||
| you would have to parse it on you own into a list |
voith
Jan 10, 2017
on you your own
on you your own
redapple
merged commit 4636bef
into
scrapy:master
1 check was pending
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I refer to https://github.com/scrapy/scrapy/blob/1.3/scrapy/spiders/__init__.py#L30
I'm too verbose and I need some feedback to start editing out.
Also, should we include something about calling
super()in subclasses?