Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: stop using tox-pip-version #5389

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Conversation

Gallaecio
Copy link
Member

Aims to fix #5388.

@Gallaecio
Copy link
Member Author

I removed the only thing that the 2 failing jobs had in common that the other jobs did not have, and it has worked.

We introduced tox-pip-version in #5207 because otherwise CI would fail. The situation now is the opposite.

I think pypa/pip#10481 may be the reason we can now use the latest pip without issues.

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #5389 (62f9d8e) into master (fe43411) will increase coverage by 0.15%.
The diff coverage is n/a.

❗ Current head 62f9d8e differs from pull request most recent head 669d4dc. Consider uploading reports for the commit 669d4dc to get more accurate results

@@            Coverage Diff             @@
##           master    #5389      +/-   ##
==========================================
+ Coverage   88.43%   88.59%   +0.15%     
==========================================
  Files         163      163              
  Lines       10651    10651              
  Branches     1816     1816              
==========================================
+ Hits         9419     9436      +17     
+ Misses        956      940      -16     
+ Partials      276      275       -1     
Impacted Files Coverage Δ
scrapy/__main__.py 0.00% <0.00%> (-33.34%) ⬇️
scrapy/robotstxt.py 97.53% <0.00%> (+22.22%) ⬆️

@Gallaecio Gallaecio merged commit 9be878f into scrapy:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI fails on Python 3.8 during dependency installation
2 participants