Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Python 3.3 support #13

Merged
merged 11 commits into from
Oct 9, 2013
Merged

[MRG] Python 3.3 support #13

merged 11 commits into from
Oct 9, 2013

Conversation

kmike
Copy link
Member

@kmike kmike commented Oct 4, 2013

All tests pass under Python 2.6, 2.7 and 3.3.

TODO:

  • add tests for w3lib.form
  • port w3lib.form

There are 2 types of changes:

  1. dealing with moved modules and changed builtins: "six" library is used for that;
  2. being more explicit about bytes and unicode: a lot of 'b's are added to constants, some tests are duplicated for byte and unicode input.

This PR should be backwards compatible besides the following:

  • w3lib.http.basic_auth_header now uses ISO-8859-1 explicitly; previously it implicitly used sys.getdefaultencoding();
  • setup.py is converted to setuptools;
  • replace_escape_chars unicode handling is fixed.

pablohoffman added a commit that referenced this pull request Oct 9, 2013
[MRG] Python 3.3 support
@pablohoffman pablohoffman merged commit 5890aa5 into scrapy:master Oct 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants