Remove tab and newlines in url.safe_url_string #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
+ Coverage 95.3% 95.32% +0.01%
==========================================
Files 7 7
Lines 469 471 +2
Branches 93 93
==========================================
+ Hits 447 449 +2
Misses 15 15
Partials 7 7
|
kmike
reviewed
Jul 11, 2019
kmike
reviewed
Jul 11, 2019
|
@kmike Applied both suggestions, thank you! |
elacuesta
changed the title
kmike
reviewed
Jul 12, 2019
Gallaecio
reviewed
Jul 15, 2019
| @@ -34,9 +34,12 @@ def _quote_byte(error): | |||
|
|
|||
| _safe_chars = RFC3986_RESERVED + RFC3986_UNRESERVED + EXTRA_SAFE_CHARS + b'%' | |||
|
|
|||
| _ascii_tab_newline_re = re.compile(r'[\t\n\r]') # see https://infra.spec.whatwg.org/#ascii-tab-or-newline | |||
There was a problem hiding this comment.
Since we are linking to the ‘living standard’, which changes constantly, I think we should not link directly to it, but through the Wayback Machine. Both here and on the docstring below.
There was a problem hiding this comment.
Wayback Machine is being blocked and unblocked in Russia, so I'm fine with whatwg link :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See scrapy/scrapy#3855
Forgive me if this is an overly naïve approach, I must admit I'm not overly familiar with the formalities of URL definition and handling.