-
Notifications
You must be signed in to change notification settings - Fork 409
Description
Pull request #6625 added string settings so you could fully customize the step increments in this addon. Then pull request #6744 changed the setting types from fully-customizable strings (which the type of which was incorrectly set, by the way; it should've been untranslated
, not string
) to decimal settings, which accept only numerical values but don't accept any values more precise than their step increments, which were set to 0.1 (except for one, which was 0.01). This led to some mixed opinions:
@WorldLanguages (posted in #6744 (comment))
Why was this merged? String settings worked just fine and were actually customizable and functionalmxmou said:
The decimal input should at least accept all values of the select setting. It's currently only possible to set "change on regular key press" to 0.01 if "use custom values" is disabled.
DNin01 said:
it would be kind of strange to put up another update notification to say the settings got even more precise
We should either revert this PR or possibly revert #6625 instead (and wait until v1.36 is released to allow for custom values in this addon).
Or as secret-chest said, "fix the steps" (tip: I had no idea what you meant by that, try being more clear such as saying 0.01 can't be entered)
Reverting would be an opportunity to have more time to discuss the best way to implement this. What should we do, @ScratchAddons/admins, @Secret-chest, @Samq64, @mxmou?
And before you say, "we'll just change it later", we can technically do that, but we're already about to say that the values are fully customizable, and I just think that if we decide to upgrade this again in the future, it would be kind of strange to announce again (in a notification, blog post, or anywhere, except the changelog, probably) that the settings became even more flexible. Once we announce our addition of these custom value fields, which weren't there from the start, they'll already feel like they're in their final form, and not really in need of an upgrade to most users. By reversing course, we don't announce the changes and can therefore announce them in whatever state they're in when we release them.
(Maybe we should also remove the select settings and "use custom values" switch and only have input fields for numbers?)