Skip to content

Switching to "random backdrop" should always select a different backdrop (Closes #521) #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 12, 2024

Conversation

aspizu
Copy link
Contributor

@aspizu aspizu commented Oct 4, 2024

Resolves: #521

Copy link
Contributor

@adazem009 adazem009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to update the test at line 2500. You'll have to set the costume index to 0 before the EXPECT_CALL though, because the default index is -1 (when there are no costumes).

stage.setCostumeIndex(0);

@adazem009 adazem009 marked this pull request as ready for review October 12, 2024 18:34
@adazem009 adazem009 merged commit 4c1db3f into scratchcpp:master Oct 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching to "random backdrop" should always select a different backdrop (if there's more than one)
2 participants