Skip to content

Conversation

adzhindzhi
Copy link
Contributor

@adzhindzhi adzhindzhi commented Oct 2, 2025

Resolves

UEPR-385

Proposed Changes

  • Use more specific selectors to override driverjs styles

Reason for Changes

Make sprites and other affected items clickable

@adzhindzhi adzhindzhi requested a review from a team as a code owner October 2, 2025 14:20
@adzhindzhi adzhindzhi requested a review from KManolov3 October 2, 2025 14:20
Copy link
Contributor

@KManolov3 KManolov3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more resilient approach for new components, that ensures such behavior out of the box and also protects against naming collisions (which css modules also do in the editor, but not in www) is to qualify styles with the container they are in, where applicable. But as far as I see in this PR - that's not applicable to all cases, so I am okay as-is.

@adzhindzhi adzhindzhi merged commit b90e507 into scratchfoundation:UEPR-282-face-sensing Oct 3, 2025
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants