[UEPR-386] Sound editor crashes #342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
UEPR-386
Proposed Changes
Reason for Changes
mapStateToProps
is not re-evaluated, so no error occurs. On subsequent deletions, however,mapStateToProps
is re-run viahandleSubsequentCalls
, which ends up callinggetSoundBuffer
whenthis.editingTarget.sprite.sounds[soundIndex]
is already empty. This bug existed before React 18, but my assumption is that the previous React-Redux implementation swallowed errors thrown insidemapStateToProps
, preventing them from surfacing. With React 18 errors thrown during render are no longer suppressed and now propagate, which is why the editor crashes after the upgrade even though the underlying bug was always present.