-
Notifications
You must be signed in to change notification settings - Fork 82
feat: uepr-38: implement debugging modal with text topics #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: uepr-38: implement debugging modal with text topics #36
Conversation
// Google Tag Manager ID | ||
// Looks like 'GTM-XXXXXXX' | ||
gtm_id: process.env.GTM_ID || '', | ||
|
||
// Google Tag Manager env & auth info for alterative GTM environments | ||
// Looks like '>m_auth=0123456789abcdefghijklm>m_preview=env-00>m_cookies_win=x' | ||
// Taken from the middle of: GTM -> Admin -> Environments -> (environment) -> Get Snippet | ||
// Blank for production | ||
gtm_env_auth: process.env.GTM_ENV_AUTH || '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of consistency, I'd recommend moving this stuff into something like:
const commonHtmlWebpackPluginOptions = {
// Google Tag Manager ID
gtm_id: // etc
};
Then you can add something like this here and in all the other pages:
.addPlugin(new HtmlWebpackPlugin({
...commonHtmlWebpackPluginOptions,
chunks: // etc
That way, all of the generated pages have the same GTM config without needing to manually copy it to each one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also worth checking with Georgi regarding how this might affect GUI stand-alone mode, if you haven't already, but I imagine it's probably fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extracted the config in a common variable and reused it for the configuration of the rest of the HtmlWebpackPlugin
's. Was that what you had in mind?
On your second point - yes, I coordinated this with Georgi.
Resolves
https://scratchfoundation.atlassian.net/browse/UEPR-38
Proposed Changes
Implements a debugging modal with text topics
Reason for Changes
Explain why these changes should be made
Test Coverage
Please show how you have added tests to cover your changes