Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenderedTarget.setSay is unused #2414

Closed
apple502j opened this issue May 18, 2020 · 1 comment · Fixed by #2415
Closed

RenderedTarget.setSay is unused #2414

apple502j opened this issue May 18, 2020 · 1 comment · Fixed by #2415
Labels
developer facing priority 3 tech debt
Milestone
Confirm Prioritiz...

Comments

@apple502j
Copy link
Contributor

RenderedTarget.setSay, which only logs something, is currently unused. (Actual code for rendering the bubble is in scratch3_looks and scratch-render.)
@adroitwhiz
Copy link
Contributor

This traces back to 460760b. Say/think bubbles were implemented in #691 but that PR didn't remove the old stub setSay.

@adroitwhiz adroitwhiz mentioned this issue May 18, 2020
Merged
@BryceLTaylor BryceLTaylor added this to the Confirm Prioritization milestone May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
developer facing priority 3 tech debt
Projects
None yet
Milestone
Confirm Prioritization
Development

Successfully merging a pull request may close this issue.

Remove RenderedTarget.setSay + its test adroitwhiz/scratch-vm
3 participants
@BryceLTaylor @adroitwhiz @apple502j