Remove RenderedTarget.setSay + its test #2415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #2414
Proposed Changes
This PR removes the
RenderedTarget.setSay
function and its unit tests.Reason for Changes
setSay
was a stub function added in 460760b that doesn't actually do anything other than log to the console, and is not called in any part of the codebase.Say/think bubble support was added in #691, but that PR didn't remove the old stub
setSay
function. As it is now,setSay
is dead code.Test Coverage
Updated as well