Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Augment Timer with documentation and self.performance.now #163

Merged
merged 2 commits into from
Sep 12, 2016
Merged

Augment Timer with documentation and self.performance.now #163

merged 2 commits into from
Sep 12, 2016

Conversation

tmickel
Copy link
Contributor

@tmickel tmickel commented Sep 8, 2016

Resolving #56 and making it more clear what each method of Timer does.

@thisandagain thisandagain assigned tmickel and unassigned thisandagain Sep 12, 2016
@thisandagain
Copy link
Contributor

thisandagain commented Sep 12, 2016 •
edited
Loading

This looks good though it doesn't hande situations where performance.now is available, but with a vendor prefix (see: https://github.com/daniellmb/perfnow.js/blob/master/perfnow.js#L13).

@tmickel tmickel merged commit ebbfe88 into scratchfoundation:develop Sep 12, 2016
@tmickel
Copy link
Contributor Author

tmickel commented Sep 12, 2016

@thisandagain Yep - although I think all of those should be under our target browser versions, and this has a fallback too. If we want we can add it.

@tmickel tmickel deleted the feature/performance-now branch September 12, 2016 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tmickel tmickel

Labels
pr - good to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmickel @thisandagain