Skip to content

Fix AWS services initialization #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

Neurostep
Copy link
Contributor

Description

In this PR we fix the AWS services initialization. SFN and SQS services were mistakenly initializing the Sagemaker and S3 clients respectively.

Testing considerations

AWS SFN and SQS configuration and clients are not yet in use, so no prior testing is required.

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@Neurostep Neurostep requested a review from a team as a code owner July 3, 2024 10:03
@Neurostep Neurostep requested review from fotos and laynax July 3, 2024 10:03
Copy link
Contributor

@laynax laynax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neurostep Neurostep merged commit b805675 into main Jul 3, 2024
@Neurostep Neurostep deleted the maksimt/fix-aws-clients-initialization branch July 3, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants