Skip to content

Conversation

Neurostep
Copy link
Contributor

@Neurostep Neurostep commented Aug 25, 2025

Description

In this PR we upgrade the Golang version to v1.25.0.

Alos, we upgrade the golangci-lint tool to v2.4.0. This is a major version upgrade and required upgrade of the .golangci.yml configuration file and some minor code changes (stylistic).

The .golangci file upgraded using the built-in migrate command:

golangci-lint migrate

Testing considerations

  • Update the go-sdk in go-chassis and check if everything works as expected

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@Copilot Copilot AI review requested due to automatic review settings August 25, 2025 10:53
@Neurostep Neurostep requested a review from a team as a code owner August 25, 2025 10:53
@Neurostep Neurostep requested a review from terranisu August 25, 2025 10:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Go version from v1.24.0 to v1.25.0 and updates golangci-lint from v1.64.8 to v2.4.0. The upgrade includes configuration file migration and stylistic code changes to comply with the new linter requirements.

  • Updated Go version to v1.25.0 across build files and documentation
  • Upgraded golangci-lint to v2.4.0 with migrated configuration file
  • Applied stylistic fixes including error message capitalization and variable declaration simplification

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
go.mod Updated Go version to 1.25.0 and removed toolchain specification
Dockerfile Updated base image and tool versions for the new Go version
README.md Updated documentation to reflect new Go version requirement
.golangci.yml Migrated configuration file to v2 format with new structure
pkg/*/config.go Capitalized error messages to follow linting standards
pkg/context/*/context.go Capitalized error messages to follow linting standards
pkg/middleware/logger_test.go Simplified variable declarations
pkg/instrumentation/kafka/kafka_test.go Updated method calls to use embedded methods

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

terranisu
terranisu previously approved these changes Aug 25, 2025
Copy link
Member

@terranisu terranisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Member

@terranisu terranisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Neurostep Neurostep merged commit f6d86df into main Aug 25, 2025
6 checks passed
@Neurostep Neurostep deleted the maksimt/DEVPLAT-5297/go-1.25 branch August 25, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants