-
Notifications
You must be signed in to change notification settings - Fork 0
[DEVPLAT-5297] Upgrade go version to v1.25.0 #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the Go version from v1.24.0 to v1.25.0 and updates golangci-lint from v1.64.8 to v2.4.0. The upgrade includes configuration file migration and stylistic code changes to comply with the new linter requirements.
- Updated Go version to v1.25.0 across build files and documentation
- Upgraded golangci-lint to v2.4.0 with migrated configuration file
- Applied stylistic fixes including error message capitalization and variable declaration simplification
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
go.mod | Updated Go version to 1.25.0 and removed toolchain specification |
Dockerfile | Updated base image and tool versions for the new Go version |
README.md | Updated documentation to reflect new Go version requirement |
.golangci.yml | Migrated configuration file to v2 format with new structure |
pkg/*/config.go | Capitalized error messages to follow linting standards |
pkg/context/*/context.go | Capitalized error messages to follow linting standards |
pkg/middleware/logger_test.go | Simplified variable declarations |
pkg/instrumentation/kafka/kafka_test.go | Updated method calls to use embedded methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
f47a36a
to
11ea8ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
Description
In this PR we upgrade the Golang version to
v1.25.0
.Alos, we upgrade the
golangci-lint
tool tov2.4.0
. This is a major version upgrade and required upgrade of the.golangci.yml
configuration file and some minor code changes (stylistic).The
.golangci
file upgraded using the built-inmigrate
command:Testing considerations
go-sdk
ingo-chassis
and check if everything works as expectedChecklist
development
and/orstaging
README.md
as necessaryRelated links