Skip to content

[SERF-2956] Upgrade lumberjack to v2.2.1 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

[SERF-2956] Upgrade lumberjack to v2.2.1 #90

merged 1 commit into from
Oct 10, 2023
+3 −4

Conversation

Neurostep
Copy link
Contributor

@Neurostep Neurostep commented Oct 10, 2023 •
edited by jira bot
Loading

Description

In this PR we are upgrading the natefinch/lumberjack.v2 library to the latest v2.2.1 version.

There is no breaking change that would affect go-sdk and/or go-chassis

Testing considerations

  • Deploy go-chassis to development and check if everything works as expected

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@Neurostep Neurostep requested a review from a team as a code owner October 10, 2023 08:33
@Neurostep Neurostep requested review from terranisu and laynax October 10, 2023 08:33
terranisu
terranisu approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@terranisu terranisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

The commit message contains the chore prefix, which won't cut a new release of the go-sdk. Is it what we want to?

@Neurostep
Copy link
Contributor Author

@terranisu

The commit message contains the chore prefix, which won't cut a new release of the go-sdk. Is it what we want to?

Yes, since there is no change that would affect go-chassis we do not want to release a new version. We will create a release when we have either a library upgrade that has an effect on go-chassis (grpc for example) or we have a batch upgrade

laynax
laynax approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@laynax laynax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neurostep Neurostep merged commit 9e3d01f into main Oct 10, 2023
@Neurostep Neurostep deleted the maksimt/SERF-2956/upgrade-lumberjack branch October 10, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terranisu terranisu terranisu approved these changes

+1 more reviewer

@laynax laynax laynax approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neurostep @terranisu @laynax