-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust
: Init project
#10
Conversation
Exciting stuff @RyanPaulGannon! Really great 😊 I'll send commits here with the changes to the docs to add in the needed Rust shields, etc :) |
Brilliant, nice one! If you need me to add anything to take some of the work off you I'm more than happy to do so 😄 I was thinking of creating the issues regarding testing in Linux and fixing the problem with macOS, but I wasn't sure whether the issues would be for when we have merged? What do you think? 😄 |
Let's get it working for Linux and Mac and then we can merge 😊 Let me know if you have other ideas on how we could get it working for Mac! |
So excited for this! 🤩🥳 Also, real quick - @RyanPaulGannon, iirc was there an error that popped up when testing on Mac? If so, would you mind adding a screenshot of it for reference? Thanks for the awesome update today!! Really great work! |
All working on my end, @RyanPaulGannon! Let's do a slight bit of cleanup of the UI, and then we can bring this in. I think we can maybe remove the Translate button for now and we can add it back in later once we discuss whether what we have for the designs is the final (having buttons on click of the Scribe key via a modal). |
Let us know when the UI's where you want it to be, and then I'll be happy to merge! |
Let us know when this is ready for a final review, @RyanPaulGannon :) Thanks for all the work here! |
@andrewtavis, let me know if there's anything else now before merging? I've spent some time trying to get to grips with the styling (the code needs splitting up, but for the moment, I've left it in |
96be0d2 adds some general files that are normally in Scribe repos like a PR template, pre-commit hooks and a shell script to update Scribe-i18n once we start working with the localizations 😊 I also added setup directions to the readme and contribution guide :) Thanks so much for the hard work here, @RyanPaulGannon! Great that we have Scribe-Desktop and Scribe-Android in the words at this point! 🚀 |
Contributor checklist
[x] This pull request is on a separate branch and not the main branch
Description
iced
GUI library for this, it has a nice (and I believe, easy to follow) structure. Sharing data between threads has also proved easier to achieve than when I tested with GTKlisten
function not running on the main thread. See this module for further detailsRelated issue