Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: Init project #10

Merged
merged 8 commits into from
Sep 1, 2024
Merged

Rust: Init project #10

merged 8 commits into from
Sep 1, 2024

Conversation

RyanPaulGannon
Copy link
Collaborator

Contributor checklist

[x] This pull request is on a separate branch and not the main branch

Description

  • Added files to setup project. Using iced GUI library for this, it has a nice (and I believe, easy to follow) structure. Sharing data between threads has also proved easier to achieve than when I tested with GTK
  • Tested as working on Windows 11 emulator
  • Currently crashes on Mac due to the listen function not running on the main thread. See this module for further details
  • Requires testing on Linux, (I can and will probably test on something like ParrotOS through an emulator soon)

Related issue

@andrewtavis
Copy link
Member

Exciting stuff @RyanPaulGannon! Really great 😊 I'll send commits here with the changes to the docs to add in the needed Rust shields, etc :)

@RyanPaulGannon
Copy link
Collaborator Author

Brilliant, nice one! If you need me to add anything to take some of the work off you I'm more than happy to do so 😄

I was thinking of creating the issues regarding testing in Linux and fixing the problem with macOS, but I wasn't sure whether the issues would be for when we have merged? What do you think? 😄

@andrewtavis
Copy link
Member

Let's get it working for Linux and Mac and then we can merge 😊 Let me know if you have other ideas on how we could get it working for Mac!

@wkyoshida
Copy link
Member

So excited for this! 🤩🥳
Will take a look on the Linux side as well and report back!


Also, real quick - @RyanPaulGannon, iirc was there an error that popped up when testing on Mac? If so, would you mind adding a screenshot of it for reference?


Thanks for the awesome update today!! Really great work!

@RyanPaulGannon
Copy link
Collaborator Author

Yeah, shoulda done that first! Et voila ..

[1] 54401 trace trap cargo run is displayed upon a single key being tapped

Screenshot 2024-03-10 at 17 47 16

@RyanPaulGannon
Copy link
Collaborator Author

Okay, so the app loads on Ubuntu 22.04 using Parallels but there looks to be some kind of driver error. I got over the errors with the x11 missing libraries through installing them. But as you can see from the screenshot that there is an error sending the event so I'm going to investigate this as well as the potential threading problem on macOS.

Screenshot 2024-03-10 at 19 29 14

@andrewtavis
Copy link
Member

All working on my end, @RyanPaulGannon! Let's do a slight bit of cleanup of the UI, and then we can bring this in. I think we can maybe remove the Translate button for now and we can add it back in later once we discuss whether what we have for the designs is the final (having buttons on click of the Scribe key via a modal).

@andrewtavis
Copy link
Member

Let us know when the UI's where you want it to be, and then I'll be happy to merge!

@andrewtavis andrewtavis linked an issue Aug 27, 2024 that may be closed by this pull request
2 tasks
@andrewtavis andrewtavis mentioned this pull request Aug 27, 2024
2 tasks
@andrewtavis
Copy link
Member

Let us know when this is ready for a final review, @RyanPaulGannon :) Thanks for all the work here!

@RyanPaulGannon
Copy link
Collaborator Author

@andrewtavis, let me know if there's anything else now before merging? I've spent some time trying to get to grips with the styling (the code needs splitting up, but for the moment, I've left it in lib.rs as its only one component). I have a few things in my head I'd like to create issues for to give others a chance to contribute should they wish - but if I end up working on them, I'm quite happy with that :)

@andrewtavis
Copy link
Member

96be0d2 adds some general files that are normally in Scribe repos like a PR template, pre-commit hooks and a shell script to update Scribe-i18n once we start working with the localizations 😊 I also added setup directions to the readme and contribution guide :)

Thanks so much for the hard work here, @RyanPaulGannon! Great that we have Scribe-Desktop and Scribe-Android in the words at this point! 🚀

@andrewtavis andrewtavis merged commit e133ef0 into scribe-org:main Sep 1, 2024
@RyanPaulGannon RyanPaulGannon deleted the develop branch October 21, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 'pythonics' from the repo
3 participants