-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Licenses and Wikimedia & Scribe screens #335
Adding Licenses and Wikimedia & Scribe screens #335
Conversation
…tedString (ex: licenses page)
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you! Maintainer checklist
|
How often does this date get refreshed @andrewtavis? Should we update it?
|
@SaurabhJamadagni, if the text of the privacy policy hasn't been updated, then we're good to keep it as is 😊 |
Will get to this in the coming days, @SaurabhJamadagni :) Am at a work retreat today and tomorrow 😊 |
No problem @andrewtavis. Have a nice time at the retreat! 😄 |
let wikidataLogoString = getCenteredImagesForWikimediaAndScribe(imageString: "wikidata.logo", imageWidth: imageWidth) | ||
|
||
let wikipediaLogoString = getCenteredImagesForWikimediaAndScribe(imageString: "wikipedia.logo", imageWidth: imageWidth) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More my curiosity - I assume that yes, but we've checked the legal stuff for using Wikimedia logos/marks (question more for @andrewtavis perhaps)? My understanding is that this would fall under this section? I haven't read the entire document, but was curious on what Scribe has thought through as far as properly including Wikimedia logos/marks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was something that was discussed as early as Data Reuse Days 2022 (my first Wikimedia event). It is strongly recommended that "reusers" of Wikidata and other Wikimedia projects directly cite where they get their information from. Wikidata is CC0, so you technically don't have to, but in conversations with Wikidata employees, editors and the general community they very much like to get recognition where possible. This is also why we have the "With data from Wikimedia" along with the Wikidata logo and Wikipedia logo on the screens for the App Store.
Legally speaking we'd fall within the section that you pointed out, @wkyoshida, but beyond that is a strong suggestion that we include the icon. There are "Powered by Wikidata" logos on the data access page, but then I'm not a big fan of those and chose to just go with the logos instead 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🚀 I was quite certain there must have been some prior conversation/recommendation from the community and was more just curious on how that had played out. Thanks for the comment! Exactly what I was wondering 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me, @SaurabhJamadagni! I made some minor comments and added some questions for next week's weekly, but it's all just spacing and coloration things that we can discuss as a team 😊 Nothing that would require changes and I want to make sure you can preserve your work flow.
Thanks for all this! Really is coming along nicely 🤩
Sounds good @andrewtavis! Looking forward to the discussion! Thanks for the review 😊 |
Thanks for the codes, @SaurabhJamadagni! 😊 |
Contributor checklist
Description
This PR adds the following:
Related issue