Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Licenses and Wikimedia & Scribe screens #335

Merged
merged 6 commits into from
Jun 28, 2023

Conversation

SaurabhJamadagni
Copy link
Collaborator

Contributor checklist


Description

This PR adds the following:

  • EN text files for Third-party licenses and Wikimedia & Scribe
  • Adds required text formatting functions to retrieve correctly attributed strings with links and images wherever necessary.
  • Pushes a new screen when the user selects the above menu items in the About section.
  • Changes Z axis of text view and corner image so that text doesn't overlap with the image.
  • Adds newline before first line of app texts to fix overlap.

Related issue

@github-actions
Copy link

github-actions bot commented Jun 26, 2023

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@SaurabhJamadagni
Copy link
Collaborator Author

How often does this date get refreshed @andrewtavis? Should we update it?

This POLICY is effective as of the 24th of May, 2022.

@andrewtavis
Copy link
Member

@SaurabhJamadagni, if the text of the privacy policy hasn't been updated, then we're good to keep it as is 😊

@andrewtavis andrewtavis self-requested a review June 26, 2023 07:49
@andrewtavis
Copy link
Member

Will get to this in the coming days, @SaurabhJamadagni :) Am at a work retreat today and tomorrow 😊

@SaurabhJamadagni
Copy link
Collaborator Author

No problem @andrewtavis. Have a nice time at the retreat! 😄

Comment on lines +206 to +208
let wikidataLogoString = getCenteredImagesForWikimediaAndScribe(imageString: "wikidata.logo", imageWidth: imageWidth)

let wikipediaLogoString = getCenteredImagesForWikimediaAndScribe(imageString: "wikipedia.logo", imageWidth: imageWidth)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More my curiosity - I assume that yes, but we've checked the legal stuff for using Wikimedia logos/marks (question more for @andrewtavis perhaps)? My understanding is that this would fall under this section? I haven't read the entire document, but was curious on what Scribe has thought through as far as properly including Wikimedia logos/marks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was something that was discussed as early as Data Reuse Days 2022 (my first Wikimedia event). It is strongly recommended that "reusers" of Wikidata and other Wikimedia projects directly cite where they get their information from. Wikidata is CC0, so you technically don't have to, but in conversations with Wikidata employees, editors and the general community they very much like to get recognition where possible. This is also why we have the "With data from Wikimedia" along with the Wikidata logo and Wikipedia logo on the screens for the App Store.

Legally speaking we'd fall within the section that you pointed out, @wkyoshida, but beyond that is a strong suggestion that we include the icon. There are "Powered by Wikidata" logos on the data access page, but then I'm not a big fan of those and chose to just go with the logos instead 🙃

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀 I was quite certain there must have been some prior conversation/recommendation from the community and was more just curious on how that had played out. Thanks for the comment! Exactly what I was wondering 👍

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, @SaurabhJamadagni! I made some minor comments and added some questions for next week's weekly, but it's all just spacing and coloration things that we can discuss as a team 😊 Nothing that would require changes and I want to make sure you can preserve your work flow.

Thanks for all this! Really is coming along nicely 🤩

@SaurabhJamadagni
Copy link
Collaborator Author

I made some minor comments and added some questions for next week's weekly, but it's all just spacing and coloration things that we can discuss as a team

Sounds good @andrewtavis! Looking forward to the discussion! Thanks for the review 😊

@andrewtavis
Copy link
Member

andrewtavis commented Jun 29, 2023

Thanks for the codes, @SaurabhJamadagni! 😊

@SaurabhJamadagni SaurabhJamadagni deleted the licenses-wiki-info branch June 29, 2023 11:43
andrewtavis added a commit that referenced this pull request Jul 5, 2023
@andrewtavis andrewtavis added the GSoC Available for Google Summer of Code participants label Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Available for Google Summer of Code participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants