Bugfixes for Issue #10 and #11 #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scriptcoded
requested changes
Oct 5, 2020
scriptcoded
requested changes
Oct 5, 2020
index.js
Outdated
Comment on lines
72
to
75
| if (sortedMatches[i].start >= upperBound) { | ||
| filteredMatches.push(sortedMatches[i]); | ||
| upperBound = sortedMatches[i].start + sortedMatches[i].length; | ||
| } |
There was a problem hiding this comment.
There also seems to be some indentation issues here. I'll make sure to get a linter set up asap...
|
Glad to be of help! I removed the semicolons (Java habit ;)) and improved the indentation, I hope it's ok now. |
|
Thank you for the fixes, and happy Hacktober! 🎉 |
scriptcoded
approved these changes
Oct 6, 2020
This was referenced Oct 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed bugfixes for Issues #10 and #11 :
#10 : Keywords at the end of a string will be cut off if they are not followed by a SPLIT_CHAR.
Quick fix: added EOL as alternative
#11 : Matches inside of other matches (e.g. strings) will be appended as duplicate substring at the end of the original match
Proposed fix: filter/remove nested matches