Skip to content

feat: mixed case keyword matching #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2022
Merged

feat: mixed case keyword matching #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ describe('unicode', () => {
.toBe('[keyword]select[clear]')
})

it('keywords (mixed case)', () => {
expect(hlUni('SElect'))
.toBe('[keyword]SElect[clear]')
})

it('special characters', () => {
expect(hlUni('='))
.toBe('[special]=[clear]')
Expand Down
2 changes: 1 addition & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const highlighters = [
{
name: 'keyword',
group: 1,
regex: new RegExp(`(^|${SPLIT_CHARS})(${keywords.join('|')})(?=${SPLIT_CHARS}|$)`, 'g')
regex: new RegExp(`(^|${SPLIT_CHARS})(${keywords.join('|')})(?=${SPLIT_CHARS}|$)`, 'gi')
},
{
name: 'special',
Expand Down
7 changes: 1 addition & 6 deletions lib/keywords.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const KEYWORDS = [
module.exports = [
'ADD',
'ADD CONSTRAINT',
'ALTER',
Expand Down Expand Up @@ -140,8 +140,3 @@ const KEYWORDS = [
'PRINT',
'OVERLAPS'
]

module.exports = [
...KEYWORDS,
...KEYWORDS.map((keyword) => keyword.toLowerCase())
]