Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(getSegments): custom highlighter #57

Merged
merged 6 commits into from
Aug 8, 2022

Conversation

mediabakery
Copy link
Contributor

@mediabakery mediabakery commented Aug 7, 2022

Besides a few minor adjustments, the functionality for generating segments from a SQL string has been transferred to a stand-alone function getSegments. Thus, it is possible to write your own highlighter. see #6

Copy link
Owner

@scriptcoded scriptcoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you for the contribution! 🎉

Also thanks for taking on issues, I don't have too much time myself. I like your implementation and just have some smaller comments and suggestions.

lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Show resolved Hide resolved
lib/index.js Show resolved Hide resolved
@mediabakery
Copy link
Contributor Author

Hey @scriptcoded,
thank you for the quick feedback. I will look into it.

@scriptcoded scriptcoded merged commit 8150d15 into scriptcoded:master Aug 8, 2022
scriptcoded added a commit that referenced this pull request Aug 8, 2022
@scriptcoded
Copy link
Owner

Released in v4.2.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants