public io size finalize in keygen time #1065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
changed the title
hero78119
force-pushed
the
feat/public_io
branch
2 times, most recently
from
a664fe8 to
ea8e760
Compare
hero78119
force-pushed
the
feat/public_io
branch
from
ea8e760 to
932707a
Compare
yczhangsjtu
reviewed
Sep 9, 2025
yczhangsjtu
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #1066
One of non-deterministic pk/vk came from PubIoTable fixed commitment length.
Previously in key-setup time there is no public io, thus PubIoTable addr is hardcode as 16 byte -> 2 word
In prove step once setup public io, then the PubIoTable addr will be dynamic extend to cover new public io, thus the fixed commitment are not identical, cause transcript challenge got different.
To fixed the root cause, we pass public io size in key setup time, and then in "prove" phase we check public io data <= public io size.