fix(api): eth_getProof crash

[colinlyguo]

1. Purpose or design rationale of this PR

Remove PoseidonCodeHash since it's only supported before Euclid.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

• Yes

4. Breaking change label

Does this PR have the breaking-change label?

• This PR is not a breaking change

Summary by CodeRabbit

• Refactor
  • Streamlined the blockchain API responses by removing the Poseidon code hash from account data.
• Chores
  • Updated the application patch version from 32 to 33 to reflect the latest release.

[coderabbitai]

Walkthrough

This update makes two primary modifications. First, the GetProof method in the blockchain API (located in internal/ethapi/api.go) has been streamlined by removing all handling of the PoseidonCodeHash. Consequently, the AccountResult output structure no longer includes this field. Second, the version patch constant in params/version.go has been incremented from 32 to 33, reflecting a new patch release.

Changes

File(s)	Change Summary
internal/ethapi/api.go	Removed the PoseidonCodeHash variable and associated logic from the GetProof method, and eliminated the field from the AccountResult struct.
params/version.go	Updated the VersionPatch constant from 32 to 33, with no other changes to the versioning logic.

Possibly related PRs

• fix: post-euclid block tracing #1119: Involves changes related to handling the PoseidonCodeHash, which aligns with the removal performed in this PR.

Suggested labels

bump-version

Suggested reviewers

• georgehao
• Thegaram
• omerfirmak

Poem

Oh, I'm a rabbit, hopping with glee,
Removing code clutter, light and free.
Poseidon fades like shadows at night,
A version bump shines ever so bright.
Codes and carrots, pure delight!
🥕🐇 Happy coding to all in sight!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e80917d and 6c2f241.

📒 Files selected for processing (1)

• internal/ethapi/api.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (go)

🔇 Additional comments (2)

internal/ethapi/api.go (2)

724-733: Good refactoring to remove direct PoseidonCodeHash field from the result structure

The code now no longer directly includes the PoseidonCodeHash in the returned AccountResult structure. This is appropriate as per the PR objective of fixing the eth_getProof crash by removing the PoseidonCodeHash, which is only supported prior to the Euclid version.

---

735-742: Conditionally add PoseidonCodeHash only when using Zktrie

This is a good solution that adds the PoseidonCodeHash to the result only when the state is a Zktrie. The conditional logic ensures that the code hash is only included when the underlying storage mechanism supports it, preventing potential crashes in environments where it's not supported.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.