feat: add missing td to rpc header #342
Merged
+44
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
CodSpeed Performance ReportMerging #342 will not alter performanceComparing Summary
|
frisitano
previously approved these changes
Sep 22, 2025
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts changes performed on this Reth PR by implementing the
rpc_blockmethod for theEthBlockforScrollEthApi, fetching the Td from provider and adding it to the header.This what tested on Sepolia for a couple of blocks and returns the correct Td (see attached screenshots).
Block 100
Block 1259081
Block 12341932