-
Notifications
You must be signed in to change notification settings - Fork 6
chore: merge upstream e9598ba5a #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…8439) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
…mxyz#18361) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
…ashblocks (paradigmxyz#18374) Co-authored-by: Nathaniel Bajo <nathanielbajo@Nathaniels-MacBook-Pro.local> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
Co-authored-by: Federico Gimenez <federico.gimenez@gmail.com>
…arse-trie semantics (paradigmxyz#18478)
…yz#18511) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: bakhtin <a@bakhtin.net>
…aradigmxyz#18870) Co-authored-by: sprites0 <199826320+sprites0@users.noreply.github.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Cargo.toml
Outdated
revm = { git = "https://github.com/scroll-tech/revm", default-features = false, features = ["enable_eip7702", "enable_eip7623"], branch = "feat/v87" } | ||
revm-bytecode = { git = "https://github.com/scroll-tech/revm", default-features = false, branch = "feat/v87" } | ||
revm-database = { git = "https://github.com/scroll-tech/revm", default-features = false, branch = "feat/v87" } | ||
revm-state = { git = "https://github.com/scroll-tech/revm", default-features = false, branch = "feat/v87" } | ||
revm-primitives = { git = "https://github.com/scroll-tech/revm", default-features = false, branch = "feat/v87" } | ||
revm-interpreter = { git = "https://github.com/scroll-tech/revm", default-features = false, branch = "feat/v87" } | ||
revm-inspector = { git = "https://github.com/scroll-tech/revm", default-features = false, branch = "feat/v87" } | ||
revm-context = { git = "https://github.com/scroll-tech/revm", default-features = false, branch = "feat/v87" } | ||
revm-context-interface = { git = "https://github.com/scroll-tech/revm", default-features = false, branch = "feat/v87" } | ||
revm-database-interface = { git = "https://github.com/scroll-tech/revm", default-features = false, branch = "feat/v87" } | ||
op-revm = { git = "https://github.com/scroll-tech/revm", default-features = false , branch = "feat/v87"} | ||
revm-scroll = { git = "https://github.com/scroll-tech/scroll-revm", default-features = false, branch = "feat/v87" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: revert back to default branch once other PRs are merged.
@@ -174,6 +175,7 @@ where | |||
} | |||
|
|||
// apply gas oracle predeploy upgrade at Feynman transition block. | |||
#[allow(clippy::collapsible_if)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks more readable without the collapse, but let me know what you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally think it's a good idea to respect clippys standards but I'm not strongly opinionated.
@@ -62,6 +62,7 @@ impl< | |||
} | |||
|
|||
// verify the receipts logs bloom and root | |||
#[allow(clippy::collapsible_if)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
CodSpeed Performance ReportMerging #346 will not alter performanceComparing Summary
|
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
220c772
to
348a029
Compare
compact-codec is expected to fail, base does not have compaction on EthereumReceipt. Read and writes work locally. |
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
No big changes in this upstream merge.