-
Notifications
You must be signed in to change notification settings - Fork 3
feat(admin rpc): add command to enable/disable automatic sequencing #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Shall we add an e2e test that invokes these rpc methods and ensures expected behaviour?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments in line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR adds a rollup node RPC namespace and two specific functions to enable/disable sequencing via this new RPC namespace. Based on examples from https://github.com/scroll-tech/reth/blob/scroll/examples/node-custom-rpc/src/main.rs and https://github.com/paritytech/jsonrpsee/blob/master/examples/examples/proc_macro.rs.
Closes #286