fix: l1 message indexing #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonastheis
requested changes
Sep 3, 2025
jonastheis
previously approved these changes
Sep 3, 2025
crates/chain-orchestrator/src/lib.rs
Outdated
| } | ||
|
|
||
| /// Computes the queue hash by taking the previous queue hash and performing a 2-to-1 hash with the | ||
| /// current transaction hash using keccak. It then applies a mask which is required for the kzg |
There was a problem hiding this comment.
nit: the mask is not required for kzg. We mask it because in the contract we also store the timestamp when the message was appended to the queue in the last few bits
There was a problem hiding this comment.
thanks for clarifying, I updated the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR modifies the indexing of L1 messages such that we correctly handle the boundary from V1 to V2. Additionally, we update the derivation pipeline to leverage the
l1_v2_message_queue_start_indexwhen it encounters a batch with aprev_l1_message_queue_hash == B256::ZERO(the first batch after the migration to the V2 message queue).Testing
I have tested this on Sepolia and it is working fine. I would propose we open an issue to improve test coverage of this, but I would like to proceed with implementing an RPC endpoint for rolling back the database to an L1 block, as it is more pressing.