Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Conversation

noel2004
Copy link
Member

@noel2004 noel2004 commented Apr 10, 2023

The 'poseidon-codehash' feature is specified for our l2geth, in which 'dual codehash' has applied so the codehash field in account can be always contained in a single scalar of the field (even the code hash for empty code). It would be waste of cost if we still apply it as a rlc of the bytes of codehash.

This PR switch each place refering codehash and assign the codehash as single scalar when 'poseidon-codehash' feature is enabled. Execpt for bytecode circuit, only unified change is required for most places in the code (replacing the calling of word_rlc to a specified code_hash function)

Following test should be passed:

  • The failed bytecode_invalid_hash_data test before
  • Regression for all the unit tests
  • A mock proving of the supercircuit on real-world trace from alpha testnet

@lispc
Copy link

lispc commented Apr 10, 2023

i will use this branch. Don't force push later.

@github-actions github-actions bot added the CI label Apr 10, 2023
@noel2004
Copy link
Member Author

dc36902 has passed a mock proving of supercircuit for traces on the alpha testnet

@github-actions github-actions bot removed the CI label Apr 11, 2023
@lispc lispc merged commit 5a8cbad into develop Apr 11, 2023
@lispc lispc deleted the fix/poseidonhash_rlc branch April 11, 2023 06:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants