Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Conversation

zhenfeizhang
Copy link

@zhenfeizhang zhenfeizhang commented Apr 20, 2023

Description

Previously, sig_is_valid in the ecdsa-circuit is checked and enforced within circuit. That means we cannot prove a signature is invalid. This PR makes sig_is_valid a return value so the caller can assert a tx is invalid.

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]


How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

  • What types of design choices did you face?
  • What decisions you have made?
  • Any valuable information that could help reviewers to think critically

@lispc
Copy link

lispc commented Apr 21, 2023

we can merge this after ci passes

@zhenfeizhang zhenfeizhang force-pushed the fix-ecdsa-sig-is-valid branch from 0e35878 to a1f6bb5 Compare April 21, 2023 13:39
@zhenfeizhang
Copy link
Author

we can merge this after ci passes

Fixed

@lispc lispc merged commit c656b97 into develop Apr 21, 2023
@lispc lispc deleted the fix-ecdsa-sig-is-valid branch April 21, 2023 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants