Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Proof compression circuit #568

Merged
merged 51 commits into from
Jul 4, 2023
Merged

Proof compression circuit #568

merged 51 commits into from
Jul 4, 2023

Conversation

zhenfeizhang
Copy link

@zhenfeizhang zhenfeizhang commented Jun 28, 2023 •
edited
Loading

Description

Proof compression circuit.

Issue Link

NA

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • proof compression circuit

Rationale

[design decisions and extended information]

How Has This Been Tested?

aggregator/tests.sh

zhenfeizhang and others added 30 commits May 8, 2023 13:48
@zhenfeizhang
impl in the clear
ebfcc84
@zhenfeizhang
implement PI aggregation in circuit
f85b0ec
@zhenfeizhang
fix clippy
c5a2e88
@zhenfeizhang
clean up
82717c5
@zhenfeizhang
[fix] supports multiple rounds per hash for PI aggregation circuit
f4082a2
@zhenfeizhang
[chore] fix clippy
fd595ef
@zhenfeizhang
impl SubCircuit for MultiBatchCircuit
c4cda3f
@zhenfeizhang
[refactor] pi aggregation circuit
e76e424
@zhenfeizhang
Merge branch 'develop' into pi-aggregation-circuit
98fba48
@zhenfeizhang
[chore] cargo fmt
a595c55
@zhenfeizhang
[feat] implement Aggregator
19a7110
@zhenfeizhang
[feat] scripts for tests
2f6bc8e
@zhenfeizhang
[fix] figure
4d66cd9
@zhenfeizhang
[chore] clean up; fix clippy; fix cargo fmt
c0f5b94
@zhenfeizhang
[fix] remove env log for tests
97f3963
@zhenfeizhang
[chore] partial address comments
fa582d8
@lispc @naure @zhenfeizhang
fix some audit issues (#512)
4f23a96 
* fix some audit issues

* fix create rw

* fix create rw

* TOB-SCROLL-5: additional assertions (#524)

Co-authored-by: Aurélien Nicolas <info@nau.re>

---------

Co-authored-by: naure <naure@users.noreply.github.com>
Co-authored-by: Aurélien Nicolas <info@nau.re>
@zhenfeizhang
[chore] update cargo lock
afa2c28
@zhenfeizhang
[chore] partial address comments
6defdc5
@zhenfeizhang
[doc] update readme for aggregator
3ff1f02
@zhenfeizhang
[fix] fix test configs and clean up
ceb68e6
@zhenfeizhang
[chore] clean up
87ecfa9
@zhenfeizhang
[chore] update cargo toml
2394703
@zhenfeizhang
cargo fmt
d822823
@zhenfeizhang
[chore] sync up with halo2-lib dev branch
7c49e41
@zhenfeizhang
[chore] update cargo lock
c3e8207
@zhenfeizhang
[fix] chain id u32 -> u64
990a2d1
@zhenfeizhang
[fix] chain id len for tests
df40b50
@zhenfeizhang
[fix] typo in scripts
a3f4aef
@lispc
Merge remote-tracking branch 'scroll/develop' into proof-aggregation-…
723f293 
…circuit
@zhenfeizhang zhenfeizhang marked this pull request as ready for review June 28, 2023 03:41
lispc
lispc reviewed Jun 28, 2023
View reviewed changes
lispc
lispc reviewed Jun 28, 2023
View reviewed changes
@lispc
Copy link

lispc commented Jun 28, 2023

final confirm before merge: can aggregator/configs/compression_{thin,wide}.config work for current super circuit?

icemelon
icemelon reviewed Jun 29, 2023
View reviewed changes
icemelon
icemelon reviewed Jun 30, 2023
View reviewed changes
lispc
lispc reviewed Jul 3, 2023
View reviewed changes
lispc
lispc reviewed Jul 3, 2023
View reviewed changes
@lispc lispc merged commit b85a2fe into develop Jul 4, 2023
@lispc lispc deleted the proof-compression-circuit branch July 4, 2023 02:29
@silathdiir silathdiir mentioned this pull request Jul 6, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@icemelon icemelon icemelon left review comments

@lispc lispc lispc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
crate-zkevm-circuits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhenfeizhang @lispc @icemelon @huwenqing0606