This repository was archived by the owner on Apr 18, 2025. It is now read-only.
fix LtChip range check #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # zkevm-circuits/src/super_circuit.rs
# Conflicts: # zkevm-circuits/src/rlp_circuit_fsm.rs # zkevm-circuits/src/rlp_circuit_fsm/dev.rs
lightsing
added a commit
that referenced
this pull request
Aug 1, 2023
# Conflicts: # zkevm-circuits/src/rlp_circuit_fsm.rs # zkevm-circuits/src/rlp_circuit_fsm/dev.rs # zkevm-circuits/src/super_circuit.rs
|
\b run testool |
|
Succeed to run testool: |
|
don't merge now. Wait for my review.. |
naure
suggested changes
Aug 3, 2023
naure
reviewed
Aug 4, 2023
naure
reviewed
Aug 4, 2023
naure
reviewed
Aug 4, 2023
naure
reviewed
Aug 4, 2023
naure
approved these changes
Aug 4, 2023
lispc
pushed a commit
that referenced
this pull request
Aug 16, 2023
* add range check * fix unconstrained * sort fields * merge import * unnecessary clone * add range check * add range table * replace Range256Table of rlp_circuit_fsm * replace u16_table of tx_circuit * use TableColumn * merge #694 * add type alias * use type alias * fix import * merge #690 and reduce LtChip use * missing q_enable * annotate lookup column * fix dev table load * add RangeCheck * minimal bug reproduce * fix test * clippy * clippy * remove print * fix exp_circuit * fix offset * add u128 and cleanup * revert to u8 table lookup * use u8 table lookup for u8 cell * fix dev_load * constrain unused cell == 0 * add explain for padding * update unusable_rows * performance fix * use Rotation::cur() * fix incorrect constraint for unused_cells * add comments describe row used * add comments to clarify the ranges Co-authored-by: Aurélien Nicolas <info@nau.re> * rename conflicted names Co-authored-by: Aurélien Nicolas <info@nau.re> * remove incorrect comment Co-authored-by: Aurélien Nicolas <info@nau.re> * explain why OFFSET_INCREMENT is 8usize * use u16 for carry_lo/hi * fix gadget test * remove unused cell constrain --------- Co-authored-by: DreamWuGit <wwuwwei@126.com> Co-authored-by: Aurélien Nicolas <info@nau.re>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.