Skip to content

Backend for managing User IDs #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 19, 2020
Merged

Backend for managing User IDs #52

merged 12 commits into from
Apr 19, 2020

Conversation

cmalfesi
Copy link
Contributor

@cmalfesi cmalfesi commented Apr 6, 2020

This PR includes:

  • Docker-compose to run MongoDB+NodeJS
  • API rest endpoints
  • Signup, login, user info
  • Support for login with Google sign up
  • Report test result

@cmalfesi cmalfesi mentioned this pull request Apr 6, 2020
Open
@ainsleys ainsleys requested a review from lacabra April 8, 2020 17:57
lacabra
lacabra suggested changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@lacabra lacabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmalfesi for this PR. Most of my feedback is improvements on the documentation, and a request for you to fix something that I believe it prevents from working.

Thanks again!

@cmalfesi
Copy link
Contributor Author

cmalfesi commented Apr 9, 2020

@lacabra I have updated the readme file and added more information about the installation process to avoid the loader.js error. There was a missing step.

@cmalfesi cmalfesi requested a review from lacabra April 12, 2020 11:34
@assafmo assafmo removed the request for review from lacabra April 19, 2020 12:24
@assafmo
Copy link
Contributor

assafmo commented Apr 19, 2020

Looks good, thanks for fixing what @lacabra requested.

@assafmo assafmo merged commit 3988f5a into scrtlabs:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@lacabra lacabra lacabra requested changes

@assafmo assafmo assafmo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmalfesi @assafmo @lacabra