-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to limit requests per user, quotas #263
Comments
What do you think of this spec? @sct @samwiseg0 Permission groups: Quotas: |
Is the common user really going to have so many users that permission groups are necessary? I feel like a default quota option would be sufficient for all but those who are hosting paid Plex shares... Especially with the Bulk Edit feature, I don't think that permission groups are necessary. |
I kind of agree with @TheCatLady here. At least for the initial version of this. A configurable default rolling period and quotas. Then the ability to modify those per user (or bulk edit them). I do like the idea of permission groups but the amount of work that will have to go into that versus just focusing on quotas is pretty immense. Let's get the feature out and look at maybe rolling them into groups in the future. |
Sounds good. But otherwise functionality wise we are in agreement? If so the quota can go into the beta roadmap and permission groups can come after that.
|
I agree with @sct and @TheCatLady. This can be a later down the road option. I just thought this would be nice for those that have quite a few users. For example, I don't impose limits on my family members or when I do they are much higher than other users. Doing that in one place would be a nice to have feature.
Yes
Yes
Yes. They should be able to see what they have available in their user page as well. |
Can you assign this to me? |
🎉 This issue has been resolved in version 1.22.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Is your feature request related to a problem? Please describe.
The ability to limit the amount of requests a particular user can make. This could be done on a per user basis or another thought would be to create permission groups that would have the limits set. That would make it easier to manage multiple users at once vs changing it per user individually.
Describe the solution you'd like
To have limits that are imposed per user/group. User feedback of their limits would also be necessary. Currently Ombi does a rolling 7 day request rate. Not sure if you would want to implement the same or have that be configurable. Other options could be x day rolling and x number per month.
The text was updated successfully, but these errors were encountered: