feat(requests): add ability to limit users requests with quotas#945
feat(requests): add ability to limit users requests with quotas#945ankarhem wants to merge 1 commit intosct:developfrom
Conversation
| quotaPeriod: 'Default Quota Period (days)', | ||
| quotaQuantity: 'Default Quota Quantity (requests)', |
There was a problem hiding this comment.
| quotaPeriod: 'Default Quota Period (days)', | |
| quotaQuantity: 'Default Quota Quantity (requests)', | |
| requestLimit: 'Default Request Limit', |
I think that while "Quota" makes sense for us as devs, "Request Limit" would be clearer and less confusing for the end user. We should also avoid parentheses in labels / field names; if parentheses are necessary, it probably needs to be reworded/renamed or have a "tip"/description added.
Also, I think that this should appear as one setting/option/row to the end user even though it's really two values, like:
Default Request Limit [ ] requests per [ ] days
We also need Yup validation on these fields ("You must enter a number of requests" / "You must enter a number of days" if the user only enters one but not the other, or a non-numeric value?).
There was a problem hiding this comment.
On second thought, the quotaPeriod setting should probably be a dropdown with options for day/week/month (we can still store the value as 1/7/30 days).
Default Request Limit [ ] requests per [ day v ]
[ week ]
[ month ]
Then, we don't need validation on that field, and the quotaQuantity setting can be optional (so quotas only apply if a value is set).
overseerr-api.yml
Outdated
| get: | ||
| summary: Get quotas for a specific user | ||
| description: | | ||
| Retrieves quota details for a user in a JSON object.. Requires the `MANAGE_USERS` permission. |
There was a problem hiding this comment.
| Retrieves quota details for a user in a JSON object.. Requires the `MANAGE_USERS` permission. | |
| Returns quota details for a user in a JSON object. Requires the `MANAGE_USERS` permission. |
|
I may be a bit late to the party, but another great addition would be the option to have separate limits for TV and Movies. |
I haven't updated this remotely but my rebased local branch does seperate this logic. You set one quota for movies, and one quota for how many seasons of TV you can request. |
* feat: create the basis for the override rules * feat: add support for sonarr and keywords to override rules * feat: apply override rules in the media request * feat: add users to override rules * fix: save the settings modified by the override rules * fix: resolve type errors * style: run prettier * fix: add missing migration * fix: correct sonarr override rules * fix: create PostgreSQL migration and fix SQLite migration * fix: resolve type naming and fix i18n issue * fix: remove unrelated changes to the PR
Description
Screenshot (if UI related)
Todos
yarn buildyarn i18n:extractIssues Fixed or Closed by this PR