Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import all users from Plex #281

Closed
samwiseg0 opened this issue Dec 15, 2020 · 13 comments · Fixed by #428
Closed

Import all users from Plex #281

samwiseg0 opened this issue Dec 15, 2020 · 13 comments · Fixed by #428
Labels

Comments

@samwiseg0
Copy link
Collaborator

samwiseg0 commented Dec 15, 2020

Is your feature request related to a problem? Please describe.
Currently, once a user logs in then you can change their permissions. I believe a better workflow would be to import all the users and be able to set permissions ahead of time.

Describe the solution you'd like
Be able to manage users before they log in. I believe a sync job to Plex to collect all the users will be needed and should be ran periodically.

@zZebrahz
Copy link

Importing the users before their initial login could also be used to allow or deny certain users to be able to use the app which would be helpful.

@XTechLabs
Copy link

Be able to manage users before they log in. I believe a sync job to Plex to collect all the users will be needed and should be ran periodically.

It would be nice to automatically remove users when they leave a Plex Server as well.

@TheChrisK
Copy link

This would be a nice option. I had a friend test out the interface and he only showed up as a user after he logged in. Only then was I able to edit his profile.

@samwiseg0
Copy link
Collaborator Author

How would should re shares be handled? Meaning let's say a user is shared with the server. We remove them but now they are re shared with the server.

@samwiseg0
Copy link
Collaborator Author

This would be a nice option. I had a friend test out the interface and he only showed up as a user after he logged in. Only then was I able to edit his profile.

This is the current workflow. I do agree this list should be all the active shared users.

@XTechLabs
Copy link

How would should re shares be handled? Meaning let's say a user is shared with the server. We remove them but now they are re shared with the server.

Probably the safe bet is to disable the user instead of removing them.

@samwiseg0
Copy link
Collaborator Author

samwiseg0 commented Dec 16, 2020

I like that idea. Same as how Tautulli handles it.

@douglasparker
Copy link
Contributor

douglasparker commented Dec 16, 2020

How would should re shares be handled? Meaning let's say a user is shared with the server. We remove them but now they are re shared with the server.

Probably the safe bet is to disable the user instead of removing them.

I agree, this is the best way to handle this.

I think accounts should be automatically enabled again when readded to the server as well.

@fenixjr
Copy link

fenixjr commented Dec 17, 2020

Currently a user's permissions can not be set until they have logged in, but in addition there is only the default "request" permission enabled upon creation. Being able to alter the default would save time from individually editing each user if you know you want every user to have "auto-approve" or "vote" settings etc.

@sct
Copy link
Owner

sct commented Dec 18, 2020

Currently a user's permissions can not be set until they have logged in, but in addition there is only the default "request" permission enabled upon creation. Being able to alter the default would save time from individually editing each user if you know you want every user to have "auto-approve" or "vote" settings etc.

Great idea. We can have a configurable default.

@sct
Copy link
Owner

sct commented Dec 18, 2020

Referencing #388 here

@doob187
Copy link
Contributor

doob187 commented Dec 20, 2020

var plexWrapper = require("plex-wrapper");
var client = new plexWrapper.PlexAPIClient("clientId", "username", "password");
 
client.getUsers().then(result => {
    // The result contains a JSON array with all the shared library users
    console.log(result);
});
 
client.getPendingUsers().then(result => {
    // The result contains a JSON array with all the pending shared library users
    console.log(result);
});
 
client.getAllUsers().then(result => {
    // The result contains a JSON array with both shared and pending shared users (Keep in mind that the properties may vary from the 2 types of user)
    console.log(result);
})

var plexWrapper = require("plex-wrapper");
var client = new plexWrapper.PlexAPIClient("clientId", "username", "password");
 
client.removeUser("userId");
client.removePendingUser("userId");


johnpyp added a commit to johnpyp/overseerr that referenced this issue Dec 21, 2020
johnpyp added a commit to johnpyp/overseerr that referenced this issue Dec 21, 2020
johnpyp added a commit to johnpyp/overseerr that referenced this issue Dec 21, 2020
johnpyp added a commit to johnpyp/overseerr that referenced this issue Dec 21, 2020
@sct sct closed this as completed in #428 Dec 21, 2020
sct pushed a commit that referenced this issue Dec 21, 2020
* feat: import users from plex

fix #281

* fix(frontend): re-enable delete user confirmation button after finished
@github-actions
Copy link

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants