Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(discord): add 'Enable Mentions' setting #1779

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

TheCatLady
Copy link
Collaborator

Description

Some admins may be sending Discord notifications to a channel that their users do not have access to.

This PR adds a setting to the Discord agent, to allow admins to enable/disable mentions (and the notification type selector in user settings).

By default, this setting is enabled, so the behavior is unchanged for users already utilizing the Discord agent.

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

N/A

@TheCatLady TheCatLady requested a review from sct as a code owner June 11, 2021 17:49
@TheCatLady TheCatLady force-pushed the feat/discord/mentions-setting branch 4 times, most recently from 233c224 to 33620a5 Compare June 20, 2021 19:45
@TheCatLady TheCatLady force-pushed the feat/discord/mentions-setting branch from 33620a5 to 606307f Compare June 23, 2021 12:52
@TheCatLady TheCatLady force-pushed the feat/discord/mentions-setting branch 2 times, most recently from 5b9db11 to abb2280 Compare July 13, 2021 13:18
@TheCatLady TheCatLady force-pushed the feat/discord/mentions-setting branch from abb2280 to cc41cb8 Compare August 24, 2021 02:12
@sct
Copy link
Owner

sct commented Sep 19, 2021

If you mention a user in a channel with no access does it actually have any effect? They won't get pinged or anything, I believe.

@TheCatLady
Copy link
Collaborator Author

If you mention a user in a channel with no access does it actually have any effect? They won't get pinged or anything, I believe.

True, but users will see the option to enable mentions in Overseerr, and may get confused as to why they aren't getting notified on Discord.

@TheCatLady TheCatLady force-pushed the feat/discord/mentions-setting branch 2 times, most recently from 7cb7ca0 to 329433d Compare September 20, 2021 04:30
@sct
Copy link
Owner

sct commented Sep 20, 2021

If you mention a user in a channel with no access does it actually have any effect? They won't get pinged or anything, I believe.

True, but users will see the option to enable mentions in Overseerr, and may get confused as to why they aren't getting notified on Discord.

I'm not sure how this PR stops them from seeing the ability to enable mentions? 🤔 Am I missing something?

@TheCatLady
Copy link
Collaborator Author

I'm not sure how this PR stops them from seeing the ability to enable mentions? 🤔 Am I missing something?

It removes the notification type selector from the Discord user notification settings, so that users cannot select notifications to receive.

@TheCatLady TheCatLady force-pushed the feat/discord/mentions-setting branch 3 times, most recently from b43360a to 4fee9b6 Compare October 14, 2021 14:19
@TheCatLady TheCatLady force-pushed the feat/discord/mentions-setting branch 2 times, most recently from 9741909 to a91da21 Compare October 18, 2021 15:48
@TheCatLady TheCatLady force-pushed the feat/discord/mentions-setting branch 2 times, most recently from 232fa4d to de5dae3 Compare October 26, 2021 21:16
@TheCatLady TheCatLady force-pushed the feat/discord/mentions-setting branch 2 times, most recently from b58d0eb to c0ebbd5 Compare January 1, 2022 03:16
@sct sct enabled auto-merge (squash) January 11, 2022 01:30
@sct sct merged commit 5f7538a into develop Jan 11, 2022
@sct sct deleted the feat/discord/mentions-setting branch January 11, 2022 01:39
@github-actions
Copy link

github-actions bot commented Apr 1, 2022

🎉 This PR is included in version 1.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants