-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(discord): add 'Enable Mentions' setting #1779
Conversation
233c224
to
33620a5
Compare
33620a5
to
606307f
Compare
5b9db11
to
abb2280
Compare
abb2280
to
cc41cb8
Compare
cc41cb8
to
dbf9407
Compare
If you mention a user in a channel with no access does it actually have any effect? They won't get pinged or anything, I believe. |
True, but users will see the option to enable mentions in Overseerr, and may get confused as to why they aren't getting notified on Discord. |
7cb7ca0
to
329433d
Compare
I'm not sure how this PR stops them from seeing the ability to enable mentions? 🤔 Am I missing something? |
It removes the notification type selector from the Discord user notification settings, so that users cannot select notifications to receive. |
329433d
to
4043611
Compare
b43360a
to
4fee9b6
Compare
9741909
to
a91da21
Compare
232fa4d
to
de5dae3
Compare
de5dae3
to
19fb8af
Compare
19fb8af
to
1ad56b4
Compare
1ad56b4
to
a97eacf
Compare
b58d0eb
to
c0ebbd5
Compare
c0ebbd5
to
4c57fbf
Compare
🎉 This PR is included in version 1.29.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Some admins may be sending Discord notifications to a channel that their users do not have access to.
This PR adds a setting to the Discord agent, to allow admins to enable/disable mentions (and the notification type selector in user settings).
By default, this setting is enabled, so the behavior is unchanged for users already utilizing the Discord agent.
Screenshot (if UI-related)
To-Dos
yarn build
yarn i18n:extract
Issues Fixed or Closed
N/A