fix(web/discover): filter duplicates in pagination

[marcofaggian]

Description

Duplicates coming directly from the TMDB API, filtered at rendering time (within useDiscover) so that a cached state at the backend is not needed.

Screenshot (if UI-related)

Before

After

To-Dos

• Successful build yarn build

Issues Fixed or Closed

• Fixes TMDB recommendations have duplicates #3499

[sct]

The performance impact of code like this is too costly for what is, at most, a very minor (and inconsistent) inconvenience of seeing double.

[marcofaggian]

@sct maybe the change is impacting too broadly?
Since the TMDB API call is returning 40 items max anyway, we could keep it specific for MovieRecommendations and TvRecommendations components.

for example:

<ListView
  items={titles.filter(
    (value, index, self) => index === self.findIndex((t) => t.id === value.id)
  )}
  isEmpty={isEmpty}
  isReachingEnd={isReachingEnd}
  isLoading={
     isLoadingInitialData || (isLoadingMore && (titles?.length ?? 0) > 0)
  }
  onScrollBottom={fetchMore}
/>

[sct]

I think it's the same deal. It doesn't really make sense to me to introduce this for such a minor inconvenience. And even though it's only 40 items, id rather not introduce code that's looping through each item X number of times for a problem that most of the time doesn't even appear.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.