improvement(require in scully.config): better support for node_modules…
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in scully config
|
|
|
This looks like a better approach than before. But... we may want to consider switching it back to a node modules, instead of the VM'd thing this is doing. Let's chat about it. |
aaronfrost
approved these changes
Dec 30, 2019
SanderElias
added a commit
that referenced
this pull request
Dec 31, 2019
* improvement(require in scully cofig): better support for node_modules in scully config * improvement(compileconfig.ts): add more complete nodeJS evrionment to config's scope * improvement(scully.config): show how to "self-register" * improvement(compileconfig): drop VM, use import instead This removes the protective VM context, to make creating plugins a bit simpler closes #122 re #107
|
closed in favor of other solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the imports in
scully.configso it can import both user files as well files fromnode_modules