Skip to content

Conversation

ccawley2011
Copy link
Member

This compiles, but has not been tested.

@digitall
Copy link
Member

Have reviewed. The code changes are limited to the PS2 port and are mostly fairly self-explanatory and unlikely to cause any regressions or build failures with the current toolchain on the buildbot.

The changes to the configure basically disable using the -pedantic GCC option (presumably as some GCC extensions are used in the system headers in newer SDK?), make some minor changes to allow Tremor to be disabled (even on older SDK where it was forced) and add the ijspcm library detection.

None of this should be an issue for older code or build toolchains, so am going to merge this as-is and the PS2 porter / power users (ie. self compiled builds) or users with buildbot builds can provide feedback if the builds start having any runtime issues. This is better than having this suffer bitrot as a PR.

@digitall digitall merged commit 174b0d1 into scummvm:master Sep 14, 2018
@ccawley2011 ccawley2011 deleted the ps2 branch September 14, 2018 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants