-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update xcode project #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update xcode project #198
Conversation
- Add new files - Remove references to missing files - Add iTunes file sharing
Well, the xcode project was already version controlled just heavily out of date. There are instructions on the scummvm wiki detailing how to compile the iPhone build using xcode, but they don't work because of this. The create_project dev tool seems to create an empty project which isn't that helpful either. I know having an up to date xcode project would have helped me when I wanted to compile scummvm, but if nobody else wants it that's cool. |
The proper solution would be to enhance create_project to recreate the iPhone xcode files, I guess... |
Yeah, you're totally right. I have just barely had a chance to look through and understand the scummvm code base let alone the dev tools to support it, so it seemed like a useful stopgap. Shall I close off this request then? On a side note: I need these changes on my personal branch in order to develop, but I don't want them to be included when I make a pull request on one of my branches. How can I go about doing that with git? |
It seems a bit ridiculous to have the project file in the tree and then reject updates to it. We could merge this, and add a TODO note about fixing create_project and add a note to the release instructions to make sure to remove the project file before doing a release, if it isn't up-to-date? Or we could argue about it a bit. |
+1 to fuzzie's suggestion here... |
Fair point, we can do as fuzzie says for now, till create_project works for xcode projects |
In case you guys plan to merge the project files, you also need to do the following:
|
Once items 3) and 4) are addressed, I would merge this request. But generally our create_project needs to be fixed. |
Any news on this? |
Some observations:
|
Update: create_project is able to create xcode project files now (when ENABLE_XCODE is set). These will need to be tested. If the generated files work, then we can create a set for the release and close this pull request. Another interesting tidbit that could be added from this pull request is iTunes file sharing, which could help users copy over game files via iTunes to their devices (is this working with ScummVM?). Plus, we could also add the UISupportedInterfaceOrientations and UISupportedInterfaceOrientations-ipad keys, if they help with orientation at all. |
The changes to create_project are just a small step, it doesn't generate a working XCode project yet. I'm very very slowly getting there but that won't be ready for this release (or probably the next one). |
Last but not least AFAIK the create_project update as for XCode development files for OS X, right? These won't work directly for iOS. |
The current project file includes targets for OSX, iPhone and iPhone simulator, so once it is complete, it will work for both (and we will probably want to merge the two folders in dist into one) |
This pull request is not going anywhere as far as I can tell and there's some work on the XCode project file generation going on, so I'm closing this one now. |
These commits: