Skip to content

Conversation

phoenixtail26
Copy link
Contributor

These commits:

  • Update the xcode project to reflect the current state of the master branch.
  • Add iTunes file sharing
  • Update icons to apple specified resolutions

- Add new files
- Remove references to missing files
- Add iTunes file sharing
@phoenixtail26
Copy link
Contributor Author

Well, the xcode project was already version controlled just heavily out of date. There are instructions on the scummvm wiki detailing how to compile the iPhone build using xcode, but they don't work because of this. The create_project dev tool seems to create an empty project which isn't that helpful either. I know having an up to date xcode project would have helped me when I wanted to compile scummvm, but if nobody else wants it that's cool.

@fingolfin
Copy link
Contributor

The proper solution would be to enhance create_project to recreate the iPhone xcode files, I guess...

@phoenixtail26
Copy link
Contributor Author

Yeah, you're totally right. I have just barely had a chance to look through and understand the scummvm code base let alone the dev tools to support it, so it seemed like a useful stopgap. Shall I close off this request then?

On a side note: I need these changes on my personal branch in order to develop, but I don't want them to be included when I make a pull request on one of my branches. How can I go about doing that with git?

@fuzzie
Copy link
Contributor

fuzzie commented Feb 23, 2012

It seems a bit ridiculous to have the project file in the tree and then reject updates to it. We could merge this, and add a TODO note about fixing create_project and add a note to the release instructions to make sure to remove the project file before doing a release, if it isn't up-to-date? Or we could argue about it a bit.

@digitall
Copy link
Member

+1 to fuzzie's suggestion here...

@bluegr
Copy link
Member

bluegr commented Feb 23, 2012

Fair point, we can do as fuzzie says for now, till create_project works for xcode projects

@lordhoto
Copy link
Contributor

In case you guys plan to merge the project files, you also need to do the following:

  1. Update our release HOWTO to say that the (iPhone) Xcode files need to be removed in release sources.
  2. Notify sev and other people working on the release managament about that addition in the HOWTO.
  3. Clearly state somewhere that the files might be outdated and that we don't give any support for them. (And probably we should update our wiki to say that the official SDK support isn't actively maintained right now).
  4. Add a proper TODO in create_project and maybe on our TODO list on the wiki.

@sev-
Copy link
Member

sev- commented Mar 17, 2012

Once items 3) and 4) are addressed, I would merge this request. But generally our create_project needs to be fixed.

@lordhoto
Copy link
Contributor

lordhoto commented Apr 2, 2012

Any news on this?

@bluegr
Copy link
Member

bluegr commented Apr 2, 2012

Some observations:

  • Commit 22a39e4 changes the icons to be according to Apple's dimensions. However, the icons for IOS devices are not supposed to have button-like effects on their own, as the OS takes care of that. Our icons do have a glossy effect, shadows and rounded edges, so I don't know if it's a good idea to make the icon sizes standard, or just recreate them with proper dimensions without any effects (shadow, gloss, rounded corners)
  • As for commit 7f5d5c1... I haven't tested it yet, but create_project doesn't create correct xcode project files at all, they're missing the actual files from each project. So it would be good to at least have an updated version

@bluegr
Copy link
Member

bluegr commented Jul 15, 2012

Update: create_project is able to create xcode project files now (when ENABLE_XCODE is set). These will need to be tested. If the generated files work, then we can create a set for the release and close this pull request.

Another interesting tidbit that could be added from this pull request is iTunes file sharing, which could help users copy over game files via iTunes to their devices (is this working with ScummVM?). Plus, we could also add the UISupportedInterfaceOrientations and UISupportedInterfaceOrientations-ipad keys, if they help with orientation at all.

@Templier
Copy link
Member

The changes to create_project are just a small step, it doesn't generate a working XCode project yet. I'm very very slowly getting there but that won't be ready for this release (or probably the next one).

@lordhoto
Copy link
Contributor

Last but not least AFAIK the create_project update as for XCode development files for OS X, right? These won't work directly for iOS.

@Templier
Copy link
Member

The current project file includes targets for OSX, iPhone and iPhone simulator, so once it is complete, it will work for both (and we will probably want to merge the two folders in dist into one)

@lordhoto
Copy link
Contributor

This pull request is not going anywhere as far as I can tell and there's some work on the XCode project file generation going on, so I'm closing this one now.

@lordhoto lordhoto closed this Jul 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants