GUI: Increase allowed number of ExtraGuiOptions #2783
Conversation
Warn and limit options when adding more ExtraGuiOptions than supported. OptionsContainerWidget passes layout to the scroll container if used.
With the changes to the themes you might need to increment the theme version (in |
I wonder if it would make more sense to take these out of the theme so they could just be procedurally added like other GameOptionsDialogs, eg. https://github.com/scummvm/scummvm/blob/master/engines/sci/detection.cpp#L384 |
@SupSuper - I'll check that out. I originally attempted something like the RemapWidget but had trouble making good layout. That example looks better. |
Procedurally generated layout works great! |
Very nice! Thanks for following @SupSuper's advice. The end result looks superb, and ticks all the right boxes:
I had added the original comment in dialogs.cpp, and the advice given then about adding all the options in the theme files is now obsolete, thanks to procedurally generated options. The end result is greatly simplified code, and a much more extendable custom options interface. I only see positive changes here, without any loss of functionality, so this is good to be merged now. Many thanks for your work! Merging |
I'll squash the commits, to keep the latest version of the code, cause the initial commits followed a different type of implementation. |
Warn and limit options when adding more ExtraGuiOptions than supported. OptionsContainerWidget passes layout to the scroll container if used.