GRIM: Fix unknown key error when loading savegame #2790
+3
−2
Conversation
| _map.erase(id); | ||
| T *t = nullptr; | ||
| if (_map.tryGetVal(id, t)) | ||
| _map.erase(id); | ||
| if (!t) { |
henke37
Feb 21, 2021
Contributor
I would've probably reused the existing if statement. It's clear from context that it's the same condition.
I would've probably reused the existing if statement. It's clear from context that it's the same condition.
criezy
Feb 21, 2021
Author
Member
I didn't know if I could assume that _map does not contain null pointers. But if that is a safe assumption we could indeed use an else statement here.
I didn't know if I could assume that _map does not contain null pointers. But if that is a safe assumption we could indeed use an else statement here.
henke37
Feb 21, 2021
Contributor
It calls a member function only a few lines bellow, no null pointers could've been stored legitimately.
It calls a member function only a few lines bellow, no null pointers could've been stored legitimately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
A user reported a crash with
Unknown key!error when trying to load a save game in MI4 today on IRC/Discord.@henke37 suggested that the likely culprit was the code changed in this pull request.
I don't have the game, and the demo doesn't let me save games. So I am unable to test this. This is why I am proposing this as a pull request so that developers who know the engine or can at least test it can validate the change.