DIRECTOR: Stub/Implement the XObjects used in Gahan Wilson's Haunted House. #3999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add to the Xtras header comments |
This also means a refactor of the AIFF Audio-decoder, to expose the two header fields we need to calculate the length.
|
Done, I was a bit unsure where to best do so, as the current comments are a mix between cpp and h, so I picked the one that was most common. While at it I also fixed a slight oddity in the copyright header (missing spaces in front of the asterisks in most lines) |
|
Oh, just realized that the branch wasn't up-to-date, the latest push should have some further cleanup as well. |
|
Excellent, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a minimal implementation of the various XObjects used in Gahan Wilson's Haunted House, of note is that this does some modifications to the common aiff-decoder to be able to implement the "Duration" query in the aiff-xobject.
The XObjects stubbed/implemented are:
This does make the intro to Gahan Wilson work a bit better, but sadly the game still doesn't progress beyond the Foyer yet.
Comments are very welcome.