Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: Stub/Implement the XObjects used in Gahan Wilson's Haunted House. #3999

Merged
merged 5 commits into from Jun 15, 2022

Conversation

somaen
Copy link
Member

@somaen somaen commented Jun 14, 2022

This adds a minimal implementation of the various XObjects used in Gahan Wilson's Haunted House, of note is that this does some modifications to the common aiff-decoder to be able to implement the "Duration" query in the aiff-xobject.

The XObjects stubbed/implemented are:

  • GPID - Product Identification Number
  • JourneyWareXINI - Windows Registry queries
  • MovUtils - MovieUtilities
  • AIFF - Mainly support for querying the duration of AIFF-files.

This does make the intro to Gahan Wilson work a bit better, but sadly the game still doesn't progress beyond the Foyer yet.

Comments are very welcome.

@sev-
Copy link
Member

@sev- sev- commented Jun 14, 2022

Please add to the Xtras header comments

 * USED IN:
     <game name>

@somaen
Copy link
Member Author

@somaen somaen commented Jun 14, 2022

Done, I was a bit unsure where to best do so, as the current comments are a mix between cpp and h, so I picked the one that was most common. While at it I also fixed a slight oddity in the copyright header (missing spaces in front of the asterisks in most lines)

@somaen
Copy link
Member Author

@somaen somaen commented Jun 14, 2022

Oh, just realized that the branch wasn't up-to-date, the latest push should have some further cleanup as well.

@sev-
Copy link
Member

@sev- sev- commented Jun 15, 2022

Excellent, thank you!

@sev- sev- merged commit b3d026a into scummvm:master Jun 15, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants