SCI: (SCI1+) - improve channel sound flag handling #4008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up some things I noticed when I implemented the mute flag handling. It removes the hack that manually forces flag 2 on all channels with number 9, regardless of the device. I presume the hack was done for the earliest SCI 1 games, due to improper handling of flag 1.
|
Great work as usual, thanks! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to
#3934
It cleans up some things I noticed when I implemented the mute flag handling. In particular, it properly implements handling of flag 1 and removes the hack that always set flag 2 on channel 9. I haven't encountered any actual bugs that would be noticeable (apparently, the hack works), so there is no hurry to merge this.
The only game where I actually encountered flag 1 usage is KQ5 (both floppy and CD).