Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCI: (SCI1+) - improve channel sound flag handling #4008

Merged
merged 1 commit into from Jun 19, 2022

Conversation

athrxx
Copy link
Member

@athrxx athrxx commented Jun 16, 2022

This is a followup to
#3934

It cleans up some things I noticed when I implemented the mute flag handling. In particular, it properly implements handling of flag 1 and removes the hack that always set flag 2 on channel 9. I haven't encountered any actual bugs that would be noticeable (apparently, the hack works), so there is no hurry to merge this.

The only game where I actually encountered flag 1 usage is KQ5 (both floppy and CD).

This cleans up some things I noticed when I implemented the mute flag handling. It removes the hack that manually forces flag 2 on all channels with number 9, regardless of the device.
I presume the hack was done for the earliest SCI 1 games, due to improper handling of flag 1.
@bluegr
Copy link
Member

@bluegr bluegr commented Jun 19, 2022

Great work as usual, thanks! Merging

@bluegr bluegr merged commit f968191 into scummvm:master Jun 19, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants