AGI: Make Gold Rush copy protection optional #6093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was bypassed in the Software Farm re-release, which was made by the original authors of the game. As a side effect, it's now possible to enable the copy protection in that version.
bluegr
reviewed
Sep 3, 2024
|
Great work, thanks! Squashing |
|
Update: Since I've tested this with many different versions of Gold Rush!, I've updated the table above with the ones I was able to test the changes with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revised version of #6011 because it was easier to start over than to deal with the changes that needed to be made and the conflicts with master. It contains the change suggested by @einstein95 to make the patch apply to all versions of the game.
To recap, my main motivation for this is that I think the copy protection in Gold Rush is interesting, so I thought it would be fun if it could be optionally enabled in the Software Farm re-release of the game. That version bypasses the copy protection because it doesn't include the necessary documentation. I'm assuming Sierra had some sort of licensing agreement, because that book was apparently written several years before the game. (I haven't been able to find out anything about the authors, but one of them has written several similar books.)
Others said that this was the dumbest idea they had ever heard (I'm editorializing a bit) and that the copy protection should be removed completely, citing its removal from the Software Farm re-release as sufficient cause to do this. I'm not sure I agree with that bit, but we don't have any really consistent policy. And if that's the compromise I have to make... But I will need help testing it. I'm particularly nervous about breaking the beautiful title screen of the older releases, because apparently that's what happened with a lot of pirated versions.
ScummVM recognizes the following versions of the game: